Skip to content

🐛 Fixes WEBSERVER_FUNCTIONS was not properly exposed to front-end #7772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2025
Merged

🐛 Fixes WEBSERVER_FUNCTIONS was not properly exposed to front-end #7772

merged 2 commits into from
May 30, 2025

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented May 30, 2025

What do these changes do?

Exposes value of WEBSERVER_FUNCTIONS both

  • to webserver service: for the front-end
  • to wb-api-server service: for the api-server

Related issue/s

How to test

Dev-ops

@pcrespov pcrespov changed the title fixes envs 🐛 Fixes WEBSERVER_FUNCTIONS was not properly exposed to front-end May 30, 2025
@pcrespov pcrespov marked this pull request as ready for review May 30, 2025 15:09
@pcrespov pcrespov self-assigned this May 30, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label May 30, 2025
@pcrespov pcrespov added this to the Bazinga! milestone May 30, 2025
@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label May 30, 2025
@pcrespov pcrespov requested a review from wvangeit May 30, 2025 15:09
@codecov
Copy link

codecov bot commented May 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (f98c431) to head (1c78c7f).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #7772       +/-   ##
===========================================
+ Coverage   72.08%   86.44%   +14.36%     
===========================================
  Files        1134     1806      +672     
  Lines       46069    69459    +23390     
  Branches      601     1215      +614     
===========================================
+ Hits        33210    60047    +26837     
+ Misses      12701     9071     -3630     
- Partials      158      341      +183
Flag Coverage Δ
integrationtests 64.27% <ø> (+0.07%) ⬆️
unittests 86.19% <ø> (-0.56%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.92% <ø> (∅)
pkg_dask_task_models_library 79.55% <ø> (ø)
pkg_models_library 93.14% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.16% <ø> (∅)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 71.85% <ø> (∅)
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.03% <ø> (-0.06%) ⬇️
agent 96.29% <ø> (ø)
api_server 91.78% <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog 92.25% <ø> (∅)
clusters_keeper 99.13% <ø> (∅)
dask_sidecar 91.67% <ø> (∅)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (∅)
director_v2 91.05% <ø> (+13.30%) ⬆️
dynamic_scheduler 96.69% <ø> (∅)
dynamic_sidecar 90.08% <ø> (+1.73%) ⬆️
efs_guardian 89.65% <ø> (ø)
invitations 93.00% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 88.87% <ø> (∅)
storage 87.46% <ø> (∅)
webclient ∅ <ø> (∅)
webserver 83.70% <ø> (+27.36%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f98c431...1c78c7f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov enabled auto-merge (squash) May 30, 2025 15:09
@pcrespov
Copy link
Member Author

pcrespov commented May 30, 2025

@mergify queue

@pcrespov pcrespov requested a review from bisgaard-itis May 30, 2025 15:10
@mergify
Copy link
Contributor

mergify bot commented May 30, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = unit-tests
        • check-skipped = unit-tests
        • check-success = unit-tests
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

wvangeit
wvangeit approved these changes May 30, 2025
View reviewed changes
Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@wvangeit wvangeit requested a review from JavierGOrdonnez May 30, 2025 15:11
@pcrespov pcrespov disabled auto-merge May 30, 2025 15:44
@pcrespov pcrespov merged commit 39f1b4f into ITISFoundation:master May 30, 2025
3 of 4 checks passed
@pcrespov pcrespov deleted the fix/function-config branch May 30, 2025 15:45
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 30, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wvangeit wvangeit wvangeit approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11 mrnicegyu11 is a code owner

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk YuryHrytsuk is a code owner

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

@JavierGOrdonnez JavierGOrdonnez Awaiting requested review from JavierGOrdonnez

Assignees

@pcrespov pcrespov

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Bazinga!

Development

Successfully merging this pull request may close these issues.

2 participants

@pcrespov @wvangeit